Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mc.tomcat.connector.sendReasonPhrase key is misplaced or doesnt apply at this location #1609

Closed
daftping opened this issue Apr 1, 2022 · 2 comments
Labels
bug Something isn't working waiting-for-public-release

Comments

@daftping
Copy link

daftping commented Apr 1, 2022

Is this a request for help?:
BUG REPORT

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Version of Helm and Kubernetes:

helm version --short
v3.7.0+geeac838
kubectl version --short
Client Version: v1.21.5
Server Version: v1.20.12-gke.1500

Which chart:
artifactory-107.35.2

What happened:

2022-04-01T16:27:50.211Z [shell] [INFO ] [] [installerCommon.sh:1603       ] [main] - Current max open processes is unlimited
.mc.tomcat.connector.sendReasonPhrase key is misplaced or doesnt apply at this location
yaml validation failed
2022-04-01T16:27:50.274Z [shell] [WARN ] [] [installerCommon.sh:791        ] [main] - System.yaml validation failed

What you expected to happen:
Valid system.yaml must be provided to Artifactory. No error messages in the logs.

How to reproduce it (as minimally and precisely as possible):
helm upgrade --install artifactory --set mc.enabled=true jfrog/artifactory

Anything else we need to know:
I don't see in the docs that .mc.tomcat.connector.sendReasonPhrase is a valid key. I think we just need to remove it here https://github.com/jfrog/charts/blob/master/stable/artifactory/values.yaml#L1469 and here https://github.com/jfrog/charts/blob/master/stable/artifactory/values.yaml#L673

@srinivasgowda097
Copy link

srinivasgowda097 commented Jun 17, 2022

Looks like below entry was not added system.full-template.yaml to validate against system.yaml, will fix in upcoming release

mc: 
     tomcat:
         connector:
             sendReasonPhrase: false

@chukka chukka added waiting-for-public-release bug Something isn't working labels Aug 4, 2022
@DLivshin
Copy link

sendReasonPhrase was deprecated with tomcat 9 https://tomcat.apache.org/tomcat-8.5-doc/config/http.html#:~:text=regexp%20matching%20disabled).-,sendReasonPhrase,-Set%20this%20attribute

We should not add it to the system.full-template.yaml, and it should be removed from the values.yaml for Artifactory and Access as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting-for-public-release
Projects
None yet
Development

No branches or pull requests

5 participants