-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xray] Adding structured system yaml to allow for individual key/value overrides #1842
[xray] Adding structured system yaml to allow for individual key/value overrides #1842
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
1fafc70
to
7642567
Compare
7642567
to
5dcd687
Compare
@nxf5025 Thanks for the PR ! we would like to review this internally and come back next week . I hope this is much needed feature every one wants to try :) |
Update : we are planning to take this feature in coming weeks, if there are any changes required to this PR , we will let you know. |
Update : we are internally evaluating refactoring systemYaml in values.yaml and would like to take this PR as part of it in next quarter , Thanks for your patience ! |
@chukka any news on the ETA ? |
@gregoryboue We are planning to take this feature in this quarter. And we will update you on the release date soon. |
@Logeshwarsn the end of the quarter is coming, any news on this feature ? |
@chukka @Logeshwarsn do you have any release date of this feature ? |
@gregoryboue Due to other priorities, there has been a delay. We are now including this feature in the 3.95.x release, scheduled for May. |
Hi, we are in may and the 3.96 has been released but this feature is not available, is it possible to have an ETA ? |
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory]
)What this PR does / why we need it:
Allows users to add/overwrite parts of the textual representation of the system.yaml after template evaluation. This allows users to provide individual overrides for the default system.yaml without needing to copy and paste the whole config.
For example:
To add the configuration talked about in this article it's as easy adding it to the structuredSystemYaml:
This would result in something like the following when fully rendered:
Special notes for your reviewer:
Inspiration is from the Mimir Helm chart - grafana/mimir#2100
If this gets accepted I will also be opening a similar PR for the Artifactory chart