Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Custom Labels #1937

Closed
pltkrt opened this issue Nov 6, 2024 · 2 comments
Closed

Adding Custom Labels #1937

pltkrt opened this issue Nov 6, 2024 · 2 comments

Comments

@pltkrt
Copy link

pltkrt commented Nov 6, 2024

I install jfrogf-platform via helm and I miss the possibility to set a custom label to all its components.

    helm repo add jfrog https://charts.jfrog.io
    helm repo update

    # Install Artifactory via Helm
    helm upgrade --install jfrog-platform jfrog/jfrog-platform \
        -f resources/values-artifactory.yaml \
        -n "jfrog-platform" \
        --create-namespace

In the values-file I don't see any flag indicating such.

@ashraf-kherbawy
Copy link

ashraf-kherbawy commented Nov 6, 2024

Hi!

The JFrog Platform chart is simply an aggregation of our product's charts. All of our sub-charts can have labels configured, you will just have to access it through it's parent keys.

For example, if you are using the Artifactory chart, you would add labels like the following to Artifactory and Nginx:

artifactory:
    labels: {}
nginx:
    labels: {}

But under the JFrog Platform chart, you need to have one extra Artifactory parent key, as a reference to the Artifactory chart:

artifactory:
    artifactory:
        labels: {}
    nginx:
        labels: {}

This same logic applies to the rest of the charts.

@pltkrt
Copy link
Author

pltkrt commented Nov 6, 2024

would be nice to set it at a single place, but yes, that worked. Thanks for that.

artifactory:
  nginx:
    labels: {"key": "value"}
  artifactory:
    labels: {"key": "value"}

@pltkrt pltkrt closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants