GNL multi-fd issue

[Sahbetdin]

Hello!

I had following malfunction with my GNL project.
The project was realised with help of linked lists.
Suppose that in main we open two files havinf fd1 and fd2.
Then we get a line from fd1 with help of our function get_next_line.
Then we get another line from fd2.
As a last step we read fd1 till it ends.

I stored remain parts of each file in linked list. For to fd's my linked list had two elements.
The problem with my gnl was that when one file ends up, I freed up all the structure. Instead of that, I should had freed only the given list with fd1.

Moulinette doesn't check that obviously. And the checker does it neither.
But one of peers paid attention to that issue.

Could you take a look into that and make checker check that?
Namely, when one file finishes, is it still possible to read a line from the other file.

Regards,
Mansur /btrifle/

[jgigault]

Hello @Sahbetdin
please provide me with the source code of your GNL
that would help me reproduce the issue and improve the checker

[Sahbetdin]

Hello Jean-Michel! Attached you can find my GNL project.  The problem with checker is as follows.In main I open several files each having its own fd.Then I read files and printf them in main. At one moment one of the files ends.In lines 136 I check if sth left in line of given fd.It returns 0 if nothing left.Then in 138 I free up the whole structure (fortunately, peers pointed to that mistake).This calls function which is located at line 96.What it does is that it cleans all the linked list though there is sth left in other descriptors. The structure saves fd as int and all previously read lines.Hope this helps. Let me know if my explanations were vague. Regards,Mansur (btrifle).  15.12.2019, 16:04, "Jean-Michel Gigault" <[email protected]>:Hello @Sahbetdinplease provide me with the source code of your GNLthat would help me reproduce the issue and improve the checker—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

[jgigault]

Hello @Sahbetdin
Attachments seem to not work with github notification. I understand the puropose of your issue but it would help me if you find a way to send me your code source :-)

[Sahbetdin]

@JgigaultSorry for thattry this link https://yadi.sk/d/rExw-lnIRNDx8w pleaseor one of my last pusheshttps://github.com/Sahbetdin/GNL/commit/18b93479c5449e43f125b7d4fb0935f3e4105744 Please let me know if you could reach the link. Regards,Mansur /btrifle/ 25.12.2019, 17:09, "Jean-Michel Gigault" <[email protected]>:Hello @Sahbetdin Attachments seem to not work with github notification. I understand the puropose of your issue but it would help me if you find a way to send me your code source :-) —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.