Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make useGitCommitTimestamp use commit timestamp instead of author timestamp #167

Open
1 task done
johanblumenberg opened this issue Dec 20, 2021 · 0 comments
Open
1 task done

Comments

@johanblumenberg
Copy link

johanblumenberg commented Dec 20, 2021

Issue

version: 1.9.0
usage context:

  • maven command line: 3.8.3

Problem description:

One reason for adding a timestamp to the version is that you want to have strictly increasing versions, where you can easily see which of two given versions is the newer one.

Currently, useGitCommitTimestamp is using the author timestamp of the commit. This is the timestamp that tells you when the author created the commit.
Then there is the commit timestamp, which is the timestamp that tells you when the commit was pushed.

Using the author timestamp as a version is a problem, because you do not gete strictly increasing versions. If I merge a PR that I have been working on for a couple of months, the version will look like it is two months old. But in fact it is the latest version, merged just a few seconds ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant