Skip to content

Latest commit

 

History

History
111 lines (86 loc) · 6.25 KB

CONTRIBUTING.md

File metadata and controls

111 lines (86 loc) · 6.25 KB
Raw

SAP Deployment Automation Framework


Contributing Guidelines

Master Branch's status: Build Status


Table of contents




Thanks for taking the time to contribute! This document summarizes the deployment principles which govern our project.

Building "in the Open"

  • Our users appreciate the transparency of our project; in this context, building "in the open" means that anyone can:
    • see the individual pull requests this solution is comprised of;
    • understand particular changes by going back and forth between pull requests;
    • submit pull requests with their own changes following the Coding Guidelines.
  • In addition, we use open-source software (OSS) tools rather than proprietary technology to build the solution.


Fully Maintained

  • Rather than providing a loose collection of scripts that are never updated, we fully maintain our project.
  • We strive to provide a high-quality solution by:
    • continuously deploying it using an internal runner to ensure performance and stability;
    • detecting regressions introduced by code changes before merging them.


Execution-focused

  • We don't just work on some grand plan that may or never be completely executed;
    • It is encouraged to make changes to gradually improve old codebase to meet standards. However, we are not planning a refactor.
    • we start building out the solution and iterate towards a grand plan.


Coding Guidelines

This repository integrates with Azure Pipelines, which invokes build checks on the submitted pull requests aginst defined branch(eg. master). ❗ All pull requests are required to pass the Azure pipelines test before it can be merged.


PR Basics

This section captures fundamentals on how new features should be developed and fixes made to the codebase.

  1. Close on design before sending PRs
    • Add and describe design by creating an issue here. Discussions on the design will happen in the issue page. How? please take a look at the example.
    • For sizable features, please request a design meeting with our team at image.
    • In the design meeting, the expectation is all attendees have reviewed the design prior to the meeting.
  2. Design for modularity, easy versioning, easy deployment and rollback
    • The design has to make sure it is independent and has minimum impact on other modules.
    • There should be a set of test cases in place to prove the design works and will not break existing code.


PR guidelines

  1. Required information in PR (example): - Always link to the issue that is is trying to resolve with tag Closes.
    • Describe the Problem that it tries to resolve.
    • Provide the Solution that this PR contains.
    • Provide Tests that have been done to make sure this PR does not break existing code (either in master or branch). If the test requires certain instructions, please add that information as well.
  2. The PRs should be easily tested independent of other projects in progress.
  3. Submit PRs with small commits with descriptive but not random comments, so that make it easier to rollback in case of problem.
  4. While the commits being small, please also make sure do not stack up too many commits (do squash if needed).
  5. If it requires several PRs for a design, please create a feature branch (name must follow feature/<feature_name> pattern, and submit PR against the feature branch instead of master (:exclamation: Make sure you alert the admin of the github repo at image to testcase for that feature branch into Azure pipeline so we make sure your PR will be tested properly).


Terraform guidelines

  1. Use // for single line comment and /* */ for block comment.
  2. Try to handle complex logic in variables_local.tf which comes in every module.
  3. Use underscore _ instead of hyphen -. The only place hyphen is used is for resource naming convention.


PR reviews guidelines

We need to ensure quality along with agility. We need to move to everyone agreeing on the base requirement and then relying on systems in place to catch and mitigate issues.

  1. Focus on the PR Basics. PRs have to adhere to Basics with no exceptions.
  2. In additional to Basics, PR reviews need to focus on the quality of a PR. eg. catching potential issues/bugs, semantic problems, nitpicks, etc...
  3. Keep PRs in an open published state for at least one working day, which would allow everyone in other regions to review.
  4. For hotfixes, keep PRs open for at least 4 business hrs.
  5. The maintainer is here.


Release strategy

  1. All new features should be added to feature branch (eg. feature/remote-tfstate2)
  2. All features should stay in beta branch until stable before get into master (eg. beta/v2.3)
  3. Only merge beta branches into master.
  4. Create releases of current master before and after merge into master.
  5. Releases naming convention: x.x.x-x (eg. 2.3.1-1)
    • major version number
    • sub version number
    • maintainance version number
    • documentation number