Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityStartup Refactoring #542

Open
maznag opened this issue Jan 5, 2021 · 5 comments · May be fixed by #1184
Open

IdentityStartup Refactoring #542

maznag opened this issue Jan 5, 2021 · 5 comments · May be fixed by #1184
Assignees
@A-5ingh
Labels
good first issue 👍 Good for newcomers refactoring refactoring the project theme: server ⚙️ up-for-grabs

Comments

@maznag
Copy link
Contributor

maznag commented Jan 5, 2021

Load users and roles seed data from csv or json file instead of hard-coding the data. See IdentityStartup.cs
@maznag maznag added theme: server ⚙️ refactoring refactoring the project labels Jan 5, 2021
@maznag maznag self-assigned this Jan 5, 2021
@nicolas63
Copy link
Member

the class is here https://github.com/jhipster/jhipster-dotnetcore/blob/main/generators/server/templates/dotnetcore/src/Project/Configuration/IdentityStartup.cs.ejs

@A-5ingh
Copy link
Contributor

A-5ingh commented Oct 2, 2022

@nicolas63 where are we planning to store the csv or json file in code? I have made the code changes to read from a csv file instead of hardcoding the data in code.

@nicolas63
Copy link
Member

Yes we can generate this file to replace our harded code

@A-5ingh
Copy link
Contributor

A-5ingh commented Oct 3, 2022

For generating we will have to again use the hardcoded values of user. I was thinking of keeping the csv file manually with all the user data and then just read it from there. You can also assign this to me.

@A-5ingh A-5ingh linked a pull request Oct 9, 2022 that will close this issue
Open
4 tasks
@A-5ingh
Copy link
Contributor

A-5ingh commented Oct 9, 2022 •
edited
Loading

@nicolas63 Please provide your review on the #1184 whenever you get time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@A-5ingh A-5ingh

Labels
good first issue 👍 Good for newcomers refactoring refactoring the project theme: server ⚙️ up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#542 Remove hard coded users details and read from csv file A-5ingh/jhipster-dotnetcore
3 participants
@nicolas63 @maznag @A-5ingh