Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of the build folder #1417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SvMak
Copy link
Contributor

@SvMak SvMak commented Nov 7, 2024

  • part of images converted to webp format;
  • remove unused images.

This should reduce the size of the build folder.

Related to: jhipster/generator-jhipster#27770

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for jhipster-site ready!

Name Link
🔨 Latest commit 55dbaf5
🔍 Latest deploy log https://app.netlify.com/sites/jhipster-site/deploys/672c9a8e53170a0008ef46b4
😎 Deploy Preview https://deploy-preview-1417--jhipster-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mraible
Copy link
Collaborator

mraible commented Nov 7, 2024

Can you add some stats on repo size before and after this change?

@SvMak
Copy link
Contributor Author

SvMak commented Nov 7, 2024

This mainly concerns the build folder, since this is what we add to our archive.

Screenshot from 2024-11-07 21-19-40

Screenshot from 2024-11-07 21-22-48

@SvMak
Copy link
Contributor Author

SvMak commented Nov 9, 2024

This mainly concerns the build folder, since this is what we add to our archive.

Screenshot from 2024-11-07 21-19-40

Screenshot from 2024-11-07 21-22-48

@mraible What do you think?

@mraible
Copy link
Collaborator

mraible commented Nov 13, 2024

If the images are converted from png to webp, does the quality decline? I remember that being a problem last time.

@SvMak
Copy link
Contributor Author

SvMak commented Nov 13, 2024

If the images are converted from png to webp, does the quality decline? I remember that being a problem last time.

Potentially yes, I used a factor of 0.75 for compression, but I didn't notice a big difference.

I would be happy if you could compare the quality of the images on your macbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants