Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop data when beginning and end are specified #92

Open
Salamandar opened this issue Feb 24, 2017 · 5 comments
Open

Crop data when beginning and end are specified #92

Salamandar opened this issue Feb 24, 2017 · 5 comments

Comments

@Salamandar
Copy link

Salamandar commented Feb 24, 2017

I have a big dataset and want to show only some of my data. I'm using beginning() and end() for that.
But the data is visible outside the axis (in the margin). The data should be cropped by beginning() and end !
error timeline

@mcmanuss8
Copy link

+1 :(

@Salamandar
Copy link
Author

I have a hack with svg clip-path. I will make a pull request.

@noahhai
Copy link

noahhai commented May 2, 2017

@Salamandar did you ever make a pull request? could you share your work-around?

@noahhai
Copy link

noahhai commented May 4, 2017

Heads up; if anyone uses zoom (not sure if only happens when setting beginning/end but I'm doing that too), you need to follow this and transform your clip-path within your zoom callback function. See: http://stackoverflow.com/questions/25142240/how-to-apply-d3-js-svg-clipping-after-zooming
I'll try to PR the fix when I have time.

@Salamandar
Copy link
Author

Hi there @noahhai. Sorry for the huge delay, but I did commit on my repo (https://github.com/Salamandar/d3-timeline), if you want to review my commit. I'll do a pull request if you want then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants