Bugfix/window is undefined for webworker #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed reference to window as globalObject for webpack bundle
|
@Aigeec seems like a great thing to fix! Unfortunately I'm not planning on working on Oboe moving forward. If you're confident with this PR, feel free to merge 👍 I've added you to the npm package as a maintainer so you can publish new versions in the future 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
There were two issues with the 2.1.5 code.
The first as noted in the issue itself was that there were some references to
windowin Oboe itself. These have been removed.The second was that with the package now bundled by webpack it also introduced a reference to
window. This is a know webpack issue (webpack/webpack#6642) (webpack/webpack#6525). I've updated the webpack config to use an expanded definition of the globalObject as per (webpack/webpack#6525 (comment))