-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SENTRY_DSN can not be defined #1655
Comments
I actually think Sentry support was removed from Jicofo, wasn't it @bgrozev ? If so we should drop it from here too. |
Just looking at the pom.xml and logging.properties on Jicofo, Jigasi and JVB, it seem to still have a reference to sentry: https://github.com/jitsi/jitsi-videobridge/blob/73fb0cf07e5627d1a6ed7131b6309af26afacd52/jvb/lib/logging.properties#L3 https://github.com/jitsi/jicofo/blob/660d7057f3db61f75a732169760ab59e79c5afaa/lib/logging.properties#L9 Looking at the config generated through the template on this repo, it shouldnt pipe Should it just check for SENTRY_DSN environment variable? Interested in this as we use Sentry too |
@saghul The PRs that remove Sentry (jitsi/jitsi-videobridge#1785 and jitsi/jicofo#854) haven't been merged. I'd still like to merge them, so they are included as dependencies only where needed. Do you have an alternative way of pulling them in for docker? |
I don't know how that would work with the library being part of the project itself. |
When trying to set SENTRY_DSN I get the following error
logging.properties
is then empty.jicofo here just stands as example. The same code is present in jigasi and jvb
The text was updated successfully, but these errors were encountered: