bug: CB wallet issue with txn simulation and popups

[divine-economy]

Essential: Please fill these out or else we won't be able to process the report

Contest Link: https://jokerace.io/contest/base/0x7ff0178871f1f5be9bcd35e3c05d17c6c82e8e94

Your Wallet Address:

Description - Please tap "copy error details" from the error message and paste it here if you're getting an error message. If you can, please include a screenshot as well:

The contract function "castVote" reverted with the following reason:
Pop up window failed to open

Contract Call:
address: 0x7ff0178871f1f5be9bcd35e3c05d17c6c82e8e94
function: castVote(uint256 proposalId, uint8 support, uint256 totalVotes, uint256 numVotes, bytes32[] proof)
args: (52431472697490844716567177889174782536741251965491159721820335599009455715508, 0, 0, {"type":"BigNumber","hex":"0x0de0b6b3a7640000"}, [])
sender: 0x288b70ec26fC1D7F2FDed321eF1e7aE44a803C5B

Docs: https://viem.sh/docs/contract/writeContract
Version: [email protected]

---

Important info

Device: iphone 14 pro

Wallet: coinbase smart wallet

Browser: brave

Telegram Handle (so we can reach you if needed):

---

Help us solve this quickly (optional)

Write out the steps for how you got from opening the browser to this error appearing:

[siobh9]

this is caused by popup blockers when there is anything between the user clicking the button and the transaction being shown to the user (in our case it's the simulation of the txn which we do to better catch not enough gas errors).

We can get rid of simulation I think because we now have the accounting correct accounting for gas, so the user should not run into situations where they are trying to send a txn that they don't have enough gas for.

That way the CB mobile wallet can work on all browsers without users having to go and manually turn off popup blockers.

[siobh9]

Can just catch all RPC errors that we don't know as a not enough gas issue, and then when exceptions come up we can implement custom erroring on a case by case basis.