Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Margins Bug? jkqtbaseplotter #146

Open
Snolandia opened this issue Nov 19, 2024 · 0 comments
Open

Possible Margins Bug? jkqtbaseplotter #146

Snolandia opened this issue Nov 19, 2024 · 0 comments

Comments

@Snolandia
Copy link
Contributor

Snolandia commented Nov 19, 2024

jkqtbaseplotter.cpp

While trying to figure out how to remove the margins from the graph, I kept having issues removing the last bit of margins. I believe these 4 lines prevent the margins from full being removed. It looks like qMax was used instead of qMin? Though I am not aware of the intentions of these lines and what changing them may break elsewhere. I changed these lines to qMin with seemingly no issues on my local.

line 919 : if (s.elongateMax>0) elongateRight=qMax(elongateRight,s.elongateMax);
line 922 : if (s.elongateMax>0) elongateRight=qMax(elongateRight,s.elongateMax);
line 928 : if (s.elongateMax>0) elongateTop=qMax(elongateTop,s.elongateMax);
line 932 : if (s.elongateMax>0) elongateTop=qMax(elongateTop,s.elongateMax);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant