Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of sending new GUID to client after receiving message body #9

Open
TysonMN opened this issue Mar 1, 2019 · 2 comments
Open

Comments

@TysonMN
Copy link
Collaborator

TysonMN commented Mar 1, 2019

After receiving the body of a message, what is the purpose of creating a new GUID and sending it to the client?

session.WriteResponse(string.Format("250 Ok: queued as {0}", Guid.NewGuid()));

If this GUID were sent more than once or added to the metadata of the received message, then this would make more sense to me. But in its current form, this code is essentially sending random data to the client (unless you consider how the GUID is generated and try to parse out the non-unique parts...which is not a good idea).

@jmarnold
Copy link
Owner

I doubt this was really thought out, lol. I don't remember why I did it.

@TysonMN
Copy link
Collaborator Author

TysonMN commented Jun 22, 2019

I can't think of any benefit. I recommend removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants