Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since PR #150 overpowering is not working as expected #174

Closed
jmcollin78 opened this issue Nov 6, 2023 · 1 comment
Closed

Since PR #150 overpowering is not working as expected #174

jmcollin78 opened this issue Nov 6, 2023 · 1 comment
Labels
bug Something isn't working developed When development is done and tested P1 Priority 1

Comments

@jmcollin78
Copy link
Owner

In PR #150 , we change the way the power is configured.
This lead to a regression in overpowering calculation.

Expected:
The overpowering calculation should calculate the max(device_power / nb_heater, device_power * on_percent) in VTherm overpowering calculation,

So that when on_percent is 100% all the power should be available, or only one heater power (in average).

@jmcollin78 jmcollin78 added bug Something isn't working P1 Priority 1 labels Nov 6, 2023
jmcollin78 pushed a commit that referenced this issue Nov 6, 2023
@jmcollin78 jmcollin78 added the developed When development is done and tested label Nov 6, 2023
@adi90x
Copy link
Contributor

adi90x commented Nov 7, 2023

Hello,
This may lead to an unsecured situation 🫤 where we fired up a heater that use more than the average.
Don't we want to secure by checking for full power available ?
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working developed When development is done and tested P1 Priority 1
Projects
None yet
Development

No branches or pull requests

2 participants