Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NSGA2 use the user-provided RNG #94

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Make NSGA2 use the user-provided RNG #94

merged 5 commits into from
Aug 31, 2023

Conversation

DaniGlez
Copy link
Contributor

No description provided.

@DaniGlez DaniGlez marked this pull request as draft August 28, 2023 15:25
@DaniGlez
Copy link
Contributor Author

Apologies for the test failures, tried to do a quick fix from the web interface but I missed the other call for tournament_selection. Will fix with a bit more care

@jmejia8
Copy link
Owner

jmejia8 commented Aug 28, 2023

Don't worry!

@DaniGlez
Copy link
Contributor Author

So, the summary of the changes would be:

  • reproduction(...) takes an additional Options arg for AbstractNSGA parameters.
  • tournament_selection(population, options, a_optional) has been changed as well

Let me know if you prefer alternative changes to these internal functions. Tests are passing now in local but I need to verify the full algorithm to see if I've missed another usage of the default RNG in this algorithm.

@DaniGlez DaniGlez marked this pull request as ready for review August 28, 2023 16:23
@DaniGlez
Copy link
Contributor Author

I think that should be it

@jmejia8
Copy link
Owner

jmejia8 commented Aug 31, 2023

Sorry for the delay. The tests have been passed. Thank you for contributing.

@jmejia8 jmejia8 merged commit 1ee4f82 into jmejia8:master Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants