Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code cleanup task #26

Open
jmrog opened this issue Jul 1, 2017 · 2 comments
Open

General code cleanup task #26

jmrog opened this issue Jul 1, 2017 · 2 comments

Comments

@jmrog
Copy link
Owner

jmrog commented Jul 1, 2017

In some cases, functions return with a large block wrapped in new Promise((resolve, reject) => { . . . }, when it probably isn't necessary (I'm not sure because I'm basing this on memory alone right now) to wrap the whole block like that. This could be cleaned up. Also consider using async/await.

@jmrog
Copy link
Owner Author

jmrog commented Nov 18, 2017

Additionally, there are unnecessarily verbose index.ts files used just for exporting. They import first and then export, when they could simply just export directly from the files.

@jmrog
Copy link
Owner Author

jmrog commented Nov 18, 2017

More: some of the code could use better typing.

@jmrog jmrog changed the title Clean up Promise code where possible General code cleanup task Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant