diff --git a/modules/maven/s2i/artifacts/usr/local/s2i/assemble b/modules/maven/s2i/artifacts/usr/libexec/s2i/assemble similarity index 100% rename from modules/maven/s2i/artifacts/usr/local/s2i/assemble rename to modules/maven/s2i/artifacts/usr/libexec/s2i/assemble diff --git a/modules/maven/s2i/artifacts/usr/local/s2i/save-artifacts b/modules/maven/s2i/artifacts/usr/libexec/s2i/save-artifacts similarity index 100% rename from modules/maven/s2i/artifacts/usr/local/s2i/save-artifacts rename to modules/maven/s2i/artifacts/usr/libexec/s2i/save-artifacts diff --git a/modules/maven/s2i/configure.sh b/modules/maven/s2i/configure.sh index 3be021b0..948c8a6a 100755 --- a/modules/maven/s2i/configure.sh +++ b/modules/maven/s2i/configure.sh @@ -8,7 +8,7 @@ ARTIFACTS_DIR=${SCRIPT_DIR}/artifacts chown -R $USER:root $SCRIPT_DIR chmod -R ug+rwX $SCRIPT_DIR chmod ug+x ${ARTIFACTS_DIR}/opt/jboss/container/maven/s2i/* -chmod ug+x ${ARTIFACTS_DIR}/usr/local/s2i/* +chmod ug+x ${ARTIFACTS_DIR}/usr/libexec/s2i/* pushd ${ARTIFACTS_DIR} cp -pr * / diff --git a/modules/run/tests/features/java.runtime.feature b/modules/run/tests/features/java.runtime.feature index bfb54ea1..2e1d58a0 100644 --- a/modules/run/tests/features/java.runtime.feature +++ b/modules/run/tests/features/java.runtime.feature @@ -10,5 +10,5 @@ Feature: Openshift OpenJDK Runtime tests (OPENJDK-474) | JAVA_DIAGNOSTICS | true | Then container log should contain /deployments/undertow-servlet.jar unique And container log should contain -XX:NativeMemoryTracking=summary - And file /usr/local/s2i/run should not contain JVM_ARGS + And file /usr/libexec/s2i/run should not contain JVM_ARGS And container log should not contain unique unique diff --git a/modules/s2i/bash/artifacts/usr/local/s2i/assemble b/modules/s2i/bash/artifacts/usr/libexec/s2i/assemble similarity index 100% rename from modules/s2i/bash/artifacts/usr/local/s2i/assemble rename to modules/s2i/bash/artifacts/usr/libexec/s2i/assemble diff --git a/modules/s2i/bash/artifacts/usr/local/s2i/run b/modules/s2i/bash/artifacts/usr/libexec/s2i/run similarity index 100% rename from modules/s2i/bash/artifacts/usr/local/s2i/run rename to modules/s2i/bash/artifacts/usr/libexec/s2i/run diff --git a/modules/s2i/bash/artifacts/usr/local/s2i/usage b/modules/s2i/bash/artifacts/usr/libexec/s2i/usage similarity index 100% rename from modules/s2i/bash/artifacts/usr/local/s2i/usage rename to modules/s2i/bash/artifacts/usr/libexec/s2i/usage diff --git a/modules/s2i/bash/configure.sh b/modules/s2i/bash/configure.sh index a56b65c9..9c039677 100755 --- a/modules/s2i/bash/configure.sh +++ b/modules/s2i/bash/configure.sh @@ -8,7 +8,7 @@ ARTIFACTS_DIR=${SCRIPT_DIR}/artifacts chown -R $USER:root $SCRIPT_DIR chmod -R ug+rwX $SCRIPT_DIR chmod ug+x ${ARTIFACTS_DIR}/opt/jboss/container/java/s2i/* -chmod ug+x ${ARTIFACTS_DIR}/usr/local/s2i/* +chmod ug+x ${ARTIFACTS_DIR}/usr/libexec/s2i/* pushd ${ARTIFACTS_DIR} cp -pr * / diff --git a/modules/s2i/core/configure.sh b/modules/s2i/core/configure.sh index b924639e..d8cd9934 100755 --- a/modules/s2i/core/configure.sh +++ b/modules/s2i/core/configure.sh @@ -13,10 +13,6 @@ pushd ${ARTIFACTS_DIR} cp -pr * / popd -mkdir -p /usr/local/s2i \ - && chmod 775 /usr/local/s2i \ - && chown -R $USER:root /usr/local/s2i - mkdir -p /deployments \ && chmod -R "ug+rwX" /deployments \ && chown -R $USER:root /deployments diff --git a/modules/s2i/core/module.yaml b/modules/s2i/core/module.yaml index 1d0938ba..eb24eb11 100644 --- a/modules/s2i/core/module.yaml +++ b/modules/s2i/core/module.yaml @@ -12,8 +12,9 @@ packages: - rsync labels: + # XXX this modules does not install files in this path - name: "io.openshift.s2i.scripts-url" - value: "image:///usr/local/s2i" + value: "image:///usr/libexec/s2i" - name: io.openshift.s2i.destination value: "/tmp" - name: org.jboss.container.deployments-dir @@ -114,7 +115,8 @@ envs: run: cmd: - - "/usr/local/s2i/run" + # XXX this script is in a different module + - "/usr/libexec/s2i/run" modules: install: diff --git a/tests/features/imagebasic.feature b/tests/features/imagebasic.feature index ceb6be8d..042082fb 100644 --- a/tests/features/imagebasic.feature +++ b/tests/features/imagebasic.feature @@ -14,4 +14,4 @@ Feature: Tests for all openshift images @ubi9/openjdk-21 Scenario: Check that builder labels are correctly set Given image is built - Then the image should contain label io.openshift.s2i.scripts-url with value image:///usr/local/s2i + Then the image should contain label io.openshift.s2i.scripts-url with value image:///usr/libexec/s2i diff --git a/ubi9-openjdk-11.yaml b/ubi9-openjdk-11.yaml index 66a48fef..ef4fbfee 100644 --- a/ubi9-openjdk-11.yaml +++ b/ubi9-openjdk-11.yaml @@ -30,8 +30,9 @@ labels: value: *version envs: + # XXX should this move to an s2i module? - name: PATH - value: $PATH:"/usr/local/s2i" + value: $PATH:"/usr/libexec/s2i" - name: "JBOSS_IMAGE_NAME" value: *name - name: "JBOSS_IMAGE_VERSION" diff --git a/ubi9-openjdk-17.yaml b/ubi9-openjdk-17.yaml index 35cd4cba..f9dc9574 100644 --- a/ubi9-openjdk-17.yaml +++ b/ubi9-openjdk-17.yaml @@ -30,8 +30,9 @@ labels: value: *version envs: + # XXX should this move to an s2i module? - name: PATH - value: $PATH:"/usr/local/s2i" + value: $PATH:"/usr/libexec/s2i" - name: "JBOSS_IMAGE_NAME" value: *name - name: "JBOSS_IMAGE_VERSION" diff --git a/ubi9-openjdk-21.yaml b/ubi9-openjdk-21.yaml index 56cab7f8..21f9e186 100644 --- a/ubi9-openjdk-21.yaml +++ b/ubi9-openjdk-21.yaml @@ -30,8 +30,9 @@ labels: value: *version envs: + # XXX should this move to an s2i module? - name: PATH - value: $PATH:"/usr/local/s2i" + value: $PATH:"/usr/libexec/s2i" - name: "JBOSS_IMAGE_NAME" value: *name - name: "JBOSS_IMAGE_VERSION"