dart_language_server broken.

[zw963]

Following is error message when working with dart-mode.

 \")\207" [#<buffer my_transactions_page.dart> (#0) eglot--managed-mode remove-hook post-command-hook nil buffer-live-p apply eglot--connect eglot--guess-contact] 4]): (file-missing "Searching for program" "No such file or directory" "dart_language_server")

From the dart-lang official document, dart start to support Dart analysis server from version 2.2.0 , now it use form like this:

dart language-server --client-id my-editor.my-plugin --client-version 1.2

Please check.

https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/tool/lsp_spec/README.md

• Server used: dart
• Emacs version: 28.1
• Operating system: Arch Linux
• Eglot version: master
• Eglot installation method: manually
• Using Doom: No

LSP transcript - M-x eglot-events-buffer (mandatory unless Emacs inoperable)

Debugger entered--Lisp error: (error "[eglot] Can't find an Eglot events buffer!")
error("[eglot] %s" "Can't find an Eglot events buffer!")
eglot--error("Can't find an Eglot events buffer!")
eglot-events-buffer(nil)
funcall-interactively(eglot-events-buffer nil)
command-execute(eglot-events-buffer record)
execute-extended-command(nil "eglot-events-buffer" "eglot-ev")
funcall-interactively(execute-extended-command nil "eglot-events-buffer" "eglot-ev")

Minimal configuration (mandatory)

(require 'eglot_init)
(add-hook 'dart-mode-hook 'eglot-ensure)

[zw963]

I don't know when to use --client-id my-editor.my-plugin or --client-version 1.2, but it seem like just work after setting like this:

(setq eglot-server-programs
      `((dart-mode . ("dart" "language-server"))))

[zw963]

This default settings never work with recent version dart, i consider this as a issue?

[joaotavora]

I confirm, the following is working for me:

If that is known to work and you want to make that the default in Eglot, submit a pull request.

What is currently preventing this discussion from being converted back to an issue?

How would that help? Issues in Eglot are meant to start with formal descriptions, almost like programs, of effects that I (or other Eglot devs) can mechanically reproduce with no domain knowledge, and little or no investigation into the domain ("dart" things, in this case). Everything else should be a discussion, where domain specific hints (like yours) are more than welcome. This seems to be a dart LS issue.

[zw963]

Sure, i can, but, if i need do somethings like this first?

Eglot is subject to the same [copyright assignment](https://www.fsf.org/licensing/contributor-faq) policy as GNU Emacs.

Any [legally significant](https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html#Legally-Significant) contributions can only be merged after the author has completed their paperwork. Please ask for the request form, and we'll send it to you.

[zw963]

PR #914

[joaotavora]

Pretty sure the change in question is legally insignificant :-D

[joaotavora]

pushed it to master.

[joaotavora]

The default dart-mode entry in eglot-server-programs should now fix the issues described.