Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next buttons sticky to vertical center of your window? #58

Open
samrgray opened this issue Nov 6, 2014 · 9 comments
Open

Next buttons sticky to vertical center of your window? #58

samrgray opened this issue Nov 6, 2014 · 9 comments
Assignees
Labels

Comments

@samrgray
Copy link
Collaborator

samrgray commented Nov 6, 2014

That was the idea — do you think this would be too much?

@kpettinga
Copy link
Collaborator

@samrgray I think it might get in the way of some content at certain points in the page. For instance, at a browser width under 1070, it would overlap the right-most filter options above the school list: http://grab.by/Ckka

@samrgray
Copy link
Collaborator Author

My feeling was that would be ok, since people can scroll to view. It definitely makes it unmissable, which is kinda a good thing. If the consensus is against though, it's fine.

@emmadwhite
Copy link
Collaborator

I agree with Sam, but Kirk, I hear your concern - at this screen size, could we move the button up? so it’s not blocking the preferences?

@kpettinga
Copy link
Collaborator

Yeah but the whole point of a sticky button is that it sticks, so eventually the user wil scroll far enough to where it will block the preferences

On Thu, Nov 20, 2014 at 3:27 AM, Emma White [email protected]
wrote:

I agree with Sam, but Kirk, I hear your concern - at this screen size, could we move the button up? so it’s not blocking the preferences?

Reply to this email directly or view it on GitHub:
#58 (comment)

@samrgray
Copy link
Collaborator Author

Emma are suggesting only having it stick on larger screens, but disabling that and letting it scroll with the page (and defining a position, like above the filters) for smaller screens?

@emmadwhite
Copy link
Collaborator

yep!

@kpettinga
Copy link
Collaborator

Oh sorry! Got it

On Thu, Nov 20, 2014 at 7:46 AM, Emma White [email protected]
wrote:

yep!

Reply to this email directly or view it on GitHub:
#58 (comment)

@kpettinga
Copy link
Collaborator

From issue #41 :
The circular button was causing some issues in terms of overlapping content and just not feeling like it "fit" anywhere. So, I updated the style and I think it flows a lot nicer with the content. In terms of having it be sticky, performance-wise it was lacking. A lot of artifacts being left behind on scroll as well as inconsistent "stickyness" on mobile.

@emmadwhite
Copy link
Collaborator

@joelmahoney if you're ok with this solution, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants