Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The docker run command in the building notes #130

Open
Ulawun opened this issue Sep 18, 2024 · 3 comments
Open

The docker run command in the building notes #130

Ulawun opened this issue Sep 18, 2024 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@Ulawun
Copy link

Ulawun commented Sep 18, 2024

Hello,

this building notes:
https://github.com/joinmarket-webui/jam-docker?tab=readme-ov-file#building-notes
say three times, that the container is to start with:

docker run --rm -it
...
joinmarket-webui/jam-ui-only

I think that is not correct !
Shouldn't it be:

docker run --rm -it
...
ghcr.io/joinmarket-webui/jam-ui-only

@theborakompanioni theborakompanioni added the question Further information is requested label Sep 18, 2024
@theborakompanioni theborakompanioni self-assigned this Sep 18, 2024
@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Sep 18, 2024

Hey @Ulawun! Thanks for the question!
This is the run command when you built the image locally (the instructions above the one you are referring to) - which is preferred to trusting the hosted image from github.
Do you have a suggestion how to improve the documentation?
Your report is highly appreciated! Thank you. 🙏

@theborakompanioni
Copy link
Collaborator

Hey @Ulawun - does the above statement make sense to you?
Do you think the issue can be closed or do you have a suggestion regarding documentation changes to make them more clear?

@Ulawun
Copy link
Author

Ulawun commented Sep 29, 2024

Thanks for the answer.
In my opinion the documentation can be improved by adding a list of commands to get the container run.
I as a non docker expert had to contact the docker community to get the container run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants