forked from realm/SwiftLint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ValidDocsRule.swift
236 lines (217 loc) · 12 KB
/
ValidDocsRule.swift
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
//
// ValidDocsRule.swift
// SwiftLint
//
// Created by JP Simard on 11/21/15.
// Copyright © 2015 Realm. All rights reserved.
//
import Foundation
import SourceKittenFramework
extension File {
fileprivate func invalidDocOffsets(in dictionary: [String: SourceKitRepresentable]) -> [Int] {
let substructure = dictionary.substructure
let substructureOffsets = substructure.flatMap(invalidDocOffsets)
guard let kind = (dictionary.kind).flatMap(SwiftDeclarationKind.init),
kind != .varParameter,
let offset = dictionary.offset,
let bodyOffset = dictionary.bodyOffset,
let comment = parseDocumentationCommentBody(dictionary, syntaxMap: syntaxMap),
!comment.contains(":nodoc:") else {
return substructureOffsets
}
let declaration = contents.bridge()
.substringWithByteRange(start: offset, length: bodyOffset - offset)!
let hasViolation = missingReturnDocumentation(declaration, comment: comment) ||
superfluousReturnDocumentation(declaration, comment: comment, kind: kind) ||
superfluousOrMissingThrowsDocumentation(declaration, comment: comment) ||
superfluousOrMissingParameterDocumentation(declaration, substructure: substructure,
offset: offset, bodyOffset: bodyOffset,
comment: comment)
return substructureOffsets + (hasViolation ? [offset] : [])
}
}
func superfluousOrMissingThrowsDocumentation(_ declaration: String, comment: String) -> Bool {
guard let outsideBracesMatch = matchOutsideBraces(declaration) else {
return false == !comment.lowercased().contains("- throws:")
}
return outsideBracesMatch.contains(" throws ") ==
!comment.lowercased().contains("- throws:")
}
func declarationReturns(_ declaration: String, kind: SwiftDeclarationKind? = nil) -> Bool {
if let kind = kind, SwiftDeclarationKind.variableKinds().contains(kind) {
return true
}
guard let outsideBracesMatch = matchOutsideBraces(declaration) else {
return false
}
return outsideBracesMatch.contains("->")
}
func matchOutsideBraces(_ declaration: String) -> NSString? {
guard let outsideBracesMatch =
regex("(?:\\)(\\s*\\w*\\s*)*((\\s*->\\s*)(\\(.*\\))*(?!.*->)[^()]*(\\(.*\\))*)?\\s*\\{)")
.matches(in: declaration, options: [],
range: NSRange(location: 0, length: declaration.bridge().length)).first else {
return nil
}
return declaration.bridge().substring(with: outsideBracesMatch.range).bridge()
}
func declarationIsInitializer(_ declaration: String) -> Bool {
let range = NSRange(location: 0, length: declaration.bridge().length)
return !regex("^((.+)?\\s+)?init\\?*\\(.*\\)")
.matches(in: declaration, options: [], range: range).isEmpty
}
func commentHasBatchedParameters(_ comment: String) -> Bool {
return comment.lowercased().contains("- parameters:")
}
func commentReturns(_ comment: String) -> Bool {
return comment.lowercased().contains("- returns:") ||
comment.range(of: "Returns")?.lowerBound == comment.startIndex
}
func missingReturnDocumentation(_ declaration: String, comment: String) -> Bool {
guard !declarationIsInitializer(declaration) else {
return false
}
return declarationReturns(declaration) && !commentReturns(comment)
}
func superfluousReturnDocumentation(_ declaration: String, comment: String,
kind: SwiftDeclarationKind) -> Bool {
guard !declarationIsInitializer(declaration) else {
return false
}
return !declarationReturns(declaration, kind: kind) && commentReturns(comment)
}
func superfluousOrMissingParameterDocumentation(_ declaration: String,
substructure: [[String: SourceKitRepresentable]],
offset: Int, bodyOffset: Int,
comment: String) -> Bool {
// This function doesn't handle batched parameters, so skip those.
if commentHasBatchedParameters(comment) { return false }
let parameterNames = substructure.filter {
($0.kind).flatMap(SwiftDeclarationKind.init) == .varParameter
}.filter { subDict in
return subDict.offset.map({ $0 < bodyOffset }) ?? false
}.flatMap {
$0.name
}
let labelsAndParams = parameterNames.map { parameter -> (label: String, parameter: String) in
let fullRange = NSRange(location: 0, length: declaration.utf16.count)
let firstMatch = regex("([^,\\s(]+)\\s+\(parameter)\\s*:")
.firstMatch(in: declaration, options: [], range: fullRange)
if let match = firstMatch {
let label = declaration.bridge().substring(with: match.rangeAt(1))
return (label, parameter)
}
return (parameter, parameter)
}
let optionallyDocumentedParameterCount = labelsAndParams.filter({ $0.0 == "_" }).count
let commentRange = NSRange(location: 0, length: comment.utf16.count)
let commentParameterMatches = regex("- [p|P]arameter ([^:]+)")
.matches(in: comment, options: [], range: commentRange)
let commentParameters = commentParameterMatches.map { match in
return comment.bridge().substring(with: match.rangeAt(1))
}
if commentParameters.count > labelsAndParams.count ||
labelsAndParams.count - commentParameters.count > optionallyDocumentedParameterCount {
return true
}
return !zip(commentParameters, labelsAndParams).filter {
![$1.label, $1.parameter].contains($0)
}.isEmpty
}
public struct ValidDocsRule: ConfigurationProviderRule {
public var configuration = SeverityConfiguration(.warning)
public init() {}
public static let description = RuleDescription(
identifier: "valid_docs",
name: "Valid Docs",
description: "Documented declarations should be valid.",
nonTriggeringExamples: [
"/// docs\npublic func a() {}\n",
"/// docs\n/// - parameter param: this is void\npublic func a(param: Void) {}\n",
"/// docs\n/// - parameter label: this is void\npublic func a(label param: Void) {}",
"/// docs\n/// - parameter param: this is void\npublic func a(label param: Void) {}",
"/// docs\n/// - Parameter param: this is void\npublic func a(label param: Void) {}",
"/// docs\n/// - returns: false\npublic func no() -> Bool { return false }",
"/// docs\n/// - Returns: false\npublic func no() -> Bool { return false }",
"/// Returns false\npublic func no() -> Bool { return false }",
"/// Returns false\nvar no: Bool { return false }",
"/// docs\nvar no: Bool { return false }",
"/// docs\n/// - throws: NSError\nfunc a() throws {}",
"/// docs\n/// - Throws: NSError\nfunc a() throws {}",
"/// docs\n/// - parameter param: this is void\n/// - returns: false" +
"\npublic func no(param: (Void -> Void)?) -> Bool { return false }",
"/// docs\n/// - parameter param: this is void" +
"\n///- parameter param2: this is void too\n/// - returns: false",
"\npublic func no(param: (Void -> Void)?, param2: String->Void) -> Bool " +
"{return false}",
"/// docs\n/// - parameter param: this is void" +
"\npublic func no(param: (Void -> Void)?) {}",
"/// docs\n/// - parameter param: this is void" +
"\n///- parameter param2: this is void too" +
"\npublic func no(param: (Void -> Void)?, param2: String->Void) {}",
"/// docs👨👩👧👧\n/// - returns: false\npublic func no() -> Bool { return false }",
"/// docs\n/// - returns: tuple\npublic func no() -> (Int, Int) {return (1, 2)}",
"/// docs\n/// - returns: closure\npublic func no() -> (Void->Void) {}",
"/// docs\n/// - parameter param: this is void" +
"\n/// - parameter param2: this is void too" +
"\nfunc no(param: (Void) -> Void, onError param2: ((NSError) -> Void)? = nil) {}",
"/// docs\n/// - parameter param: this is a void closure" +
"\n/// - parameter param2: this is a void closure too" +
"\n/// - parameter param3: this is a void closure too" +
"\nfunc a(param: () -> Void, param2: (parameter: Int) -> Void, " +
"param3: (parameter: Int) -> Void) {}",
"/// docs\n/// - parameter param: this is a void closure" +
"\n/// - Parameter param2: this is a void closure too" +
"\n/// - Parameter param3: this is a void closure too" +
"\nfunc a(param: () -> Void, param2: (parameter: Int) -> Void, " +
"param3: (parameter: Int) -> Void) {}",
"/// docs\n/// - parameter param: this is a void closure" +
"\n/// - returns: Foo<Void>" +
"\nfunc a(param: () -> Void) -> Foo<Void> {return Foo<Void>}",
"/// docs\n/// - parameter param: this is a void closure" +
"\n/// - returns: Foo<Void>" +
"\nfunc a(param: () -> Void) -> Foo<[Int]> {return Foo<[Int]>}",
"/// docs\n/// - throws: NSError\n/// - returns: false" +
"\nfunc a() throws -> Bool { return true }",
"/// docs\n/// - parameter param: this is a closure\n/// - returns: Bool" +
"\nfunc a(param: (Void throws -> Bool)) -> Bool { return true }"
],
triggeringExamples: [
"/// docs\npublic ↓func a(param: Void) {}\n",
"/// docs\n/// - parameter invalid: this is void\npublic ↓func a(param: Void) {}",
"/// docs\n/// - parameter invalid: this is void\npublic ↓func a(label param: Void) {}",
"/// docs\n/// - parameter invalid: this is void\npublic ↓func a() {}",
"/// docs\npublic ↓func no() -> Bool { return false }",
"/// Returns false\npublic ↓func a() {}",
"/// docs\n/// - throws: NSError\n↓func a() {}",
"/// docs\n↓func a() throws {}",
"/// docs\n/// - parameter param: this is void" +
"\npublic ↓func no(param: (Void -> Void)?) -> Bool { return false }",
"/// docs\n/// - parameter param: this is void" +
"\n///- parameter param2: this is void too" +
"\npublic ↓func no(param: (Void -> Void)?, param2: String->Void) -> " +
"Bool {return false}",
"/// docs\n/// - parameter param: this is void\n/// - returns: false" +
"\npublic ↓func no(param: (Void -> Void)?) {}",
"/// docs\n/// - parameter param: this is void" +
"\n///- parameter param2: this is void too\n/// - returns: false" +
"\npublic ↓func no(param: (Void -> Void)?, param2: String->Void) {}",
"/// docs\npublic func no() -> (Int, Int) {return (1, 2)}",
"/// docs\n/// - parameter param: this is void" +
"\n///- parameter param2: this is void too\n///- returns: closure" +
"\nfunc no(param: (Void) -> Void, onError param2: ((NSError) -> Void)? = nil) {}",
"/// docs\n/// - parameter param: this is a void closure" +
"\nfunc a(param: () -> Void) -> Foo<Void> {return Foo<Void>}",
"/// docs\n/// - parameter param: this is a void closure" +
"\nfunc a(param: () -> Void) -> Foo<[Int]> {return Foo<[Int]>}",
"/// docs\nfunc a() throws -> Bool { return true }"
]
)
public func validate(file: File) -> [StyleViolation] {
return file.invalidDocOffsets(in: file.structure.dictionary).map {
StyleViolation(ruleDescription: type(of: self).description,
severity: configuration.severity,
location: Location(file: file, byteOffset: $0))
}
}
}