Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unaligned read of MIDIPacket::length triggers UB check in recent Rust #17

Closed
Boddlnagg opened this issue May 9, 2024 · 0 comments · Fixed by #18
Closed

Unaligned read of MIDIPacket::length triggers UB check in recent Rust #17

Boddlnagg opened this issue May 9, 2024 · 0 comments · Fixed by #18

Comments

@Boddlnagg
Copy link
Contributor

See chris-zen/coremidi#49.

Because MIDIPackets are unaligned on non-ARM platforms, accesing their length and timeStamp fields must happen through read_unaligned. But this is not needed (and would produce worse machine code) on ARM.

These checks have been added in Rust 1.70 (https://releases.rs/docs/1.70.0/, rust-lang/rust#98112).
@Boddlnagg Boddlnagg mentioned this issue May 20, 2024
Merged
jonas-k pushed a commit that referenced this issue Jun 11, 2024
@Boddlnagg
Fix MIDIPacketNext to not trigger Rust's UB check (#18)
c2ff432 
This should fix #17.

It also simplifies MIDIEventPacketNext, which doesn't need the platform-specific distinction, as the size is 4-byte aligned anyways (see also https://github.com/phracker/MacOSX-SDKs/blob/041600eda65c6a668f66cb7d56b7d1da3e8bcc93/MacOSX11.3.sdk/System/Library/Frameworks/CoreMIDI.framework/Versions/A/Headers/MIDIServices.h#L2387).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MIDIPacketNext to not trigger Rust's UB check Boddlnagg/coremidi-sys
1 participant
@Boddlnagg