Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Models #946

Open
mbabker opened this issue Feb 17, 2017 · 0 comments
Open

Refactor Models #946

mbabker opened this issue Feb 17, 2017 · 0 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented Feb 17, 2017

In the Framework, Joomla\Model\ModelInterface and abstract classes are deprecated and removed in the 2.0 branch; the functionality is replaced with feature specific interfaces and traits.

The view package's dependency to the model package is deprecated and removed in the 2.0 branch. This means the Joomla\View\BaseHtmlView constructor only has one argument; the Joomla\Renderer\RendererInterface implementation and the Joomla\View\BaseJsonView and Joomla\View\AbstractView classes have no default constructor.

So our model and view structure will need some cleanup for this. For the view class stuff, this should basically mean adding an extended constructor in JTracker\View\AbstractTrackerHtmlView with the model argument. Since the interfaces in the Framework's model package might not always apply to all of our models (unless they really all are database and state aware), we'll probably need an empty JTracker\Model\ModelInterface our models implement to satisfy this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant