[4.1] Install from Web css and invisible badges #36547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR corrects a bug with the border radius of the search box in rtl (as shown below) and completely removes all the RTL specific css and uses logical properties instead. Also removes a few bits of css that are just not needed at all
joomla-cms-bot
added
NPM Resource Changed
Quy
reviewed
Jan 5, 2022
brianteeman
changed the title
|
I have tested this item ✅ successfully on c8bf92e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36547. |
1 similar comment
This comment was marked as abuse.
This comment was marked as abuse.
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36547. |
brianteeman
changed the title
|
rebased to 4.1 |
|
Thx |
|
thanks |
|
Thanks @brianteeman, this solve part of point 2 of this issue ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug with the border radius of the search box in rtl (as shown below) and completely removes all the RTL specific css and uses logical properties instead.
The markup uses badge-color but bs5 only has bg-color so the badges were invisible. Also the hover on the card was white on white and that was invisible before
Also removes a few bits of css that are just not needed at all
RTL before
RTL after
Badges & Hover Before
Badges & Hover After