[5.3] add composer scripts for cs check and add excludes to php-cs-fixer config #44498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Add commands
composer run phpcs
composer run csfixer
to composer.json for running cs check same way as it is configured in our automated testing setup, to make it easy for contributors to run it locally.
Add excludes for
cache
andlogs
directory to php-cs-fixer configuration as we have the same exlcudes for phpcs.Improvement for our nice contributors.
Testing Instructions
Open a terminal (and step into the cloned joomla developement folder)
composer i
composer run phpcs
composer run csfixer
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Update codestyle.md Manual#337
No documentation changes for manual.joomla.org needed