Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Augment the page header class in article #44505

Open
wants to merge 1 commit into
base: 5.3-dev
Choose a base branch
from

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Nov 22, 2024

Pull Request for Issue #42739 .

Summary of Changes

Change classes for <div class="page-header">
to

<div class="page-header menu">
<div class="page-header article">

Testing Instructions

see #42739, inspect the source code before and after patch

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Nov 22, 2024

I have tested this item ✅ successfully on 6cc6bb4

Before applying this Pull Request After applying this Pull Request
Untitled Untitled2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44505.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 6cc6bb4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44505.

@Quy
Copy link
Contributor

Quy commented Nov 22, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44505.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants