Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With reusable self-hosted runners docker containers are not removed #28

Open
loicalbertin opened this issue Jan 18, 2024 · 0 comments · May be fixed by #29
Open

With reusable self-hosted runners docker containers are not removed #28

loicalbertin opened this issue Jan 18, 2024 · 0 comments · May be fixed by #29

Comments

@loicalbertin
Copy link

Hi there 👋

I'm using your action on self-hosted runners.
In my configuration the host were the robot-reporter container runs is reused.
Consequently, after completion these containers are never removed.

I suggest to add the --rm option when running the container here:

https://github.com/joonvena/robotframework-reporter-action/blob/413a90b26bb8a49eebc51af51f1631500ef0339d/report.sh#L3C1-L3C1

WDYT?

Thanks & have a nice day!
loicalbertin added a commit to loicalbertin/robotframework-reporter-action that referenced this issue Jan 30, 2024
@loicalbertin
feat: automatically delete container on completion
0d64880 
Simply added the `--rm` docker flag to automatically delete the container upon completion.

This is particularly useful when running the action on self-hosted runners. 

Closes joonvena#28
@loicalbertin loicalbertin linked a pull request Jan 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: automatically delete container on completion loicalbertin/robotframework-reporter-action
1 participant
@loicalbertin