This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
fix: LargeBinary to LargeList should be taken as a special #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
- Coverage 83.37% 83.34% -0.03%
==========================================
Files 388 388
Lines 42200 42212 +12
==========================================
Hits 35183 35183
- Misses 7017 7029 +12
☔ View full report in Codecov by Sentry. |
|
I have tested this in pola-rs/polars#10625 and that CI has passed. |
|
@ritchie46, would you mind taking a look at this, thanks! |
ritchie46
approved these changes
Aug 21, 2023
|
Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the order is important as
LargeBinary=>LargeListis a little special.