Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy server for puppeteer usage #24

Open
eliorp opened this issue Nov 11, 2020 · 3 comments
Open

Add proxy server for puppeteer usage #24

eliorp opened this issue Nov 11, 2020 · 3 comments

Comments

@eliorp
Copy link

eliorp commented Nov 11, 2020

Hey,
I know puppeteer has an option to add a proxy server to the flow, I wonder why you didn't give this option as well.
I add this option to your code, please give me permission to PR, if you like this addition.
for my needs, it really helps!

Thanks,
Elior.

@jvandenaardweg
Copy link
Contributor

jvandenaardweg commented Nov 11, 2020

Hi!

I know puppeteer has an option to add a proxy server to the flow, I wonder why you didn't give this option as well.

Feel free to create a PR that allows you to pass additional Puppeteer options.

I add this option to your code, please give me permission to PR, if you like this addition.

As far as i'm aware, everyone can already create a PR. Fork the repo and create a PR from your fork here.

@eliorp
Copy link
Author

eliorp commented Nov 11, 2020

YAY.

So I did PR please check:)
Include proxy and automate refresh expired session cookie

@eliorp
Copy link
Author

eliorp commented Nov 16, 2020

Hey, any news about my PR?
I think about adding to response the cookie, it will be helpful in case the session cookie expired, and the project got a new session cookie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants