Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of IGeoPoint instead of GeoPoint #82

Open
GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Open

Use of IGeoPoint instead of GeoPoint #82

GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

I was in need of my own implementation of IGeoPoint for some internal purpose, 
only to see the osmbonuspack uses the plain old implemented GeoPoint for no 
apparent reason.

With a read only copy of the project, using IGeoPoint where i'd needed it seems 
to work flawlessly, save for the position.close used in Marker.setPosition. I 
use a direct assignation because i can live with the side effect.

I am not skilled enough both in Java neither in your library to dare a commit, 
but I think it may be beneficial to use the osmdroid.api interfaces instead of 
the hardcoded object.

This is just my opinion. Your pack is awesome and totally needed with OSMDroid !

Thanks.

Original issue reported on code.google.com by [email protected] on 21 Aug 2014 at 1:59

@GoogleCodeExporter
Copy link
Author

My previous attempt to use IGeoPoint was leading to a lot of casting needed. 

For your need, sub-classing GeoPoint was not feasible?
Is your need restricted to Marker, or does it apply to other classes?

I would also be interested if other users express such a need. 

Original comment by [email protected] on 25 Aug 2014 at 10:47

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

My GeoPoint was already subclassing another class, and since Java didn't allow 
multiple inheritance, I can only use IGeoPoint in this case.

My need was quite simple, I only needed that for Marker. I haven't gone deep in 
the pack.

Original comment by [email protected] on 25 Aug 2014 at 10:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant