Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field filters on a dimension called action triggers pluralize #98

Open
owlas opened this issue Nov 25, 2024 · 0 comments
Open

Field filters on a dimension called action triggers pluralize #98

owlas opened this issue Nov 25, 2024 · 0 comments

Comments

@owlas
Copy link

owlas commented Nov 25, 2024

There is handling for special keywords in this file:

"action",

Including action

The problem is that if I have a filter on a dimension called action it doesn't correctly parse

lkml

measure broken {
  type: count
  filters: {
    name: oliver
    action: click
  }
}

parsed object

Leads to this value for filters__all

# actual
[{'name': 'oliver'}, {'actions': ['click'']}]

# should be
[{'name': 'oliver'}, {'action': 'click'}]

^ action becomes actions and the filter values go into an array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant