Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path parameters in front of query #47 #48

Merged

Conversation

NoahKamara
Copy link
Contributor

this removes a statically provided query before setting path parameters and appends it again afterwards
I've also added a test for the issue

Copy link
Owner

@joshuawright11 joshuawright11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you!

@joshuawright11 joshuawright11 merged commit ab5f147 into joshuawright11:main Mar 13, 2024
2 checks passed
@NoahKamara NoahKamara deleted the fix-path-params-static-query branch March 13, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants