util: Use build target name as log file name #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So write to nvapi.log, nvapi64.log and nvofapi64.log separately.
jp7677
force-pushed
the
log-file-name
branch
from
b09fe59 to
70b5ce4
Compare
jp7677
commented
Nov 29, 2024
| @@ -81,8 +81,7 @@ namespace dxvk::log { | |||
| std::setfill('0'), std::setw(3), milliseconds, ":", | |||
| std::setfill('0'), std::setw(4), std::hex, ::GetCurrentProcessId(), ":", | |||
| std::setfill('0'), std::setw(4), std::hex, ::GetCurrentThreadId(), ":", | |||
| level, ":", | |||
| DXVK_NVAPI_TARGET_NAME, ":", | |||
| level, ":" DXVK_NVAPI_TARGET_NAME ":", | |||
There was a problem hiding this comment.
I had needed some time to get used to the idea ;)
Saancreed
approved these changes
Nov 29, 2024
Thanks ;). I haven't mentioned, but this is also to avoid any potentially weird things with writing to the same file from different dll's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So write to nvapi.log, nvapi64.log and nvofapi64.log separately.