Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

課題の表示変更 #55

Merged
merged 6 commits into from
Nov 15, 2024
Merged

課題の表示変更 #55

merged 6 commits into from
Nov 15, 2024

Conversation

Kubosaka
Copy link
Collaborator

@Kubosaka Kubosaka commented Nov 14, 2024

概要

  • 課題の表示画面の修正

変更内容

  • どのような変更を行ったのか具体的に記述してください。
スクリーンショット 2024-11-15 2 59 44 image

動作確認

  • どのような手順で動作確認を行ったのか記述してください。

関連するIssue

  • 関連するIssue番号を記載してください。例: #123

備考

  • その他、レビュワーに伝えたいことがあれば記述してください。

@TkymHrt TkymHrt requested a review from hikahana November 14, 2024 19:10
@Kubosaka
Copy link
Collaborator Author

@TkymHrt コンフリクト解消お願いします?

@TkymHrt TkymHrt requested a review from harata-t November 15, 2024 14:00
@Kubosaka
Copy link
Collaborator Author

LGTM
(approveできないです)

Copy link
Collaborator

@hikahana hikahana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
ボタンの処理を変えてもよさげ

Comment on lines 181 to 187
<Button
onClick={() => router.push("/ranking")}
className="w-full bg-gradient-to-r from-pink-500 to-purple-500 text-white font-semibold py-3 px-6 rounded-full hover:from-pink-600 hover:to-purple-600 transition duration-300"
>
結果を確認する
<LuArrowRight className="ml-2 w-5 h-5" />
</Button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button
onClick={() => router.push("/ranking")}
className="w-full bg-gradient-to-r from-pink-500 to-purple-500 text-white font-semibold py-3 px-6 rounded-full hover:from-pink-600 hover:to-purple-600 transition duration-300"
>
結果を確認する
<LuArrowRight className="ml-2 w-5 h-5" />
</Button>
<Button className="w-full bg-gradient-to-r from-pink-500 to-purple-500 text-white font-semibold py-3 px-6 rounded-full hover:from-pink-600 hover:to-purple-600 transition duration-300">
結果を確認する
<Link href="/ranking">
<LuArrowRight className="ml-2 w-5 h-5" />
</Link>

next/linkの形式にした方がいいかも

@Kubosaka Kubosaka merged commit ed8fda5 into main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants