From a6bdfee0ef5f58236f727841a2839651994a6947 Mon Sep 17 00:00:00 2001
From: Murtuza Chhil <chhil@users.noreply.github.com>
Date: Wed, 14 Aug 2024 07:53:27 +0530
Subject: [PATCH] Update Metrics.java

Changed dumped value format to use .7f precision.
Added 50ieth percentile
Changed the % used for percentile to P
Added conversion variable to allow changing the output number by divided by the conversion factor, handy when your recorded amounts are nanoseconds and need to show milliseconds.
---
 jpos/src/main/java/org/jpos/util/Metrics.java | 30 +++++++++++++------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/jpos/src/main/java/org/jpos/util/Metrics.java b/jpos/src/main/java/org/jpos/util/Metrics.java
index cddf27436c..ec1eea10ce 100644
--- a/jpos/src/main/java/org/jpos/util/Metrics.java
+++ b/jpos/src/main/java/org/jpos/util/Metrics.java
@@ -28,6 +28,7 @@
 public class Metrics implements Loggeable {
     private Histogram template;
     private Map<String,Histogram> metrics = new ConcurrentHashMap<>();
+    private double conversion = 1;
 
     public Metrics(Histogram template) {
         super();
@@ -78,17 +79,18 @@ public void dump (PrintStream ps, String indent) {
     }
 
     private void dumpPercentiles (PrintStream ps, String indent, String key, Histogram h) {
-        ps.printf ("%s%s min=%d, max=%d, mean=%.4f stddev=%.4f 90%%=%d, 99%%=%d, 99.9%%=%d, 99.99%%=%d tot=%d size=%d%n",
+          ps.printf("%s%s min=%.7f, max=%.7f, mean=%.7f stddev=%.7f P50=%.7f, P90=%.7f, P99=%.7f, P99.9=%.7f, P99.99=%.7f tot=%d size=%d%n",
           indent,
           key,
-          h.getMinValue(),
-          h.getMaxValue(),
-          h.getMean(),
-          h.getStdDeviation(),
-          h.getValueAtPercentile(90.0),
-          h.getValueAtPercentile(99.0),
-          h.getValueAtPercentile(99.9),
-          h.getValueAtPercentile(99.99),
+          h.getMinValue()/conversion,
+          h.getMaxValue()/conversion,
+          h.getMean()/conversion,
+          h.getStdDeviation()/conversion,
+          h.getValueAtPercentile(50.0)/conversion,                    
+          h.getValueAtPercentile(90.0)/conversion,
+          h.getValueAtPercentile(99.0)/conversion,
+          h.getValueAtPercentile(99.9)/conversion,
+          h.getValueAtPercentile(99.99)/conversion,
           h.getTotalCount(),
           h.getEstimatedFootprintInBytes()
         );
@@ -108,4 +110,14 @@ public void dumpHistograms (File dir, String prefix) {
           .sorted(Map.Entry.comparingByKey())
           .forEach(e -> dumpHistogram (dir, prefix + e.getKey(), e.getValue().copy()));
     }
+
+    /**
+     * @param conversion
+     *            This is used to divide the percentile values while dumping. 
+     *            If you are using nano seconds to record and want to display the numbers in millis then conversion can be set to 1000000.
+     *            By default conversion is set to 1.
+     */
+    public void setConversion(double conversion) {
+        this.conversion = conversion;
+    }
 }