Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for @3x for iPhone 6 Plus and @4x for whatever uses that #23

Open
ptarjan opened this issue May 28, 2015 · 5 comments
Open

Look for @3x for iPhone 6 Plus and @4x for whatever uses that #23

ptarjan opened this issue May 28, 2015 · 5 comments

Comments

@ptarjan
Copy link
Contributor

ptarjan commented May 28, 2015

Can you look for the other extensions when the pixel density calls for it please?

Ideally you'd use the @2x if the @3x didn't exist.

@faceleg
Copy link
Collaborator

faceleg commented Aug 23, 2015

Now accepting pull requests!

@paulcsiki
Copy link

I'm also interested in support for @3x.

@jrief
Copy link
Owner

jrief commented Mar 5, 2016

I did not know that there are any @3x devices out there. When Apple started to ship their first @2x devices, they told us, that now pixels are smaller than the resolution of the retina in our eyes, hence its name. So as you say, there are devices out there which offer more that @2x?

@ptarjan
Copy link
Contributor Author

ptarjan commented Mar 5, 2016

http://stackoverflow.com/questions/25781422/image-resolution-for-new-iphone-6-and-6-3x-support-added

Sent from my iPhone

On Mar 5, 2016, at 2:27 PM, Jacob Rief [email protected] wrote:

I did not know that there are any @3x devices out there. When Apple started to ship their first @2x devices, they told us, that now pixels are smaller than the resolution of the retina in our eyes, hence its name. So as you say, there are devices out there which offer more that @2x?


Reply to this email directly or view it on GitHub.

@faceleg
Copy link
Collaborator

faceleg commented Mar 14, 2016

It is my opinion that were this to be added, it should be hidden behind config flag and / or an optional attribute. I certainly won't be modifying my Lambda image resize function to generate 1x, 2x and 3x versions of the various image sizes I need in my app.

As a user, I would strongly disapprove of a website attempting to download a 3x image simply because I'm on a 6+.

Bandwidth is getting cheap, yes - but it is still limited and I personally do not want it wasted on pixels I almost certainly wouldn't notice.

Don't know about you @jrief but if there was a PR adding this, I would require:

  • Off by default
  • Able to be enabled globally via a config setting
  • Able to be selectively enabled via an additional attribute e.g. ng-src-3x
  • Unit tests proving the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants