-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for @3x for iPhone 6 Plus and @4x for whatever uses that #23
Comments
Now accepting pull requests! |
I'm also interested in support for @3x. |
http://stackoverflow.com/questions/25781422/image-resolution-for-new-iphone-6-and-6-3x-support-added Sent from my iPhone
|
It is my opinion that were this to be added, it should be hidden behind config flag and / or an optional attribute. I certainly won't be modifying my Lambda image resize function to generate 1x, 2x and 3x versions of the various image sizes I need in my app. As a user, I would strongly disapprove of a website attempting to download a 3x image simply because I'm on a 6+. Bandwidth is getting cheap, yes - but it is still limited and I personally do not want it wasted on pixels I almost certainly wouldn't notice. Don't know about you @jrief but if there was a PR adding this, I would require:
|
Can you look for the other extensions when the pixel density calls for it please?
Ideally you'd use the @2x if the @3x didn't exist.
The text was updated successfully, but these errors were encountered: