Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromaprint missing from versions 5.x onwards #411

Open
simonv3 opened this issue Nov 1, 2024 · 2 comments
Open

chromaprint missing from versions 5.x onwards #411

simonv3 opened this issue Nov 1, 2024 · 2 comments

Comments

@simonv3
Copy link

simonv3 commented Nov 1, 2024

This PR here added chromaprint and enabled it for all versions up to 4.4. I'm guessing it's not included in versions past 4.4 because they didn't exist at the time?

Curious if it could be added?
@simonv3
Copy link
Author

simonv3 commented Nov 1, 2024

Aha, looks like chromaprint was disabled here: disable chromaprint until
https://github.com/acoustid/chromaprint/pull/108

That looks like it's been addressed acoustid/chromaprint#108 @jrottenberg what do you think of re-enabling chromaprint?

@jrottenberg
Copy link
Owner

I'd love to, it seems fixed : acoustid/chromaprint#120 (on Nov 4, 2022)

but not released : Dec 22, 2021 - v1.5.1 is the latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrottenberg @simonv3