🐛 Multiple request params on HttpParams not honored.

[bjornharvold]

I just installed this plugin with the settings you defined in the readme in my AppModule. Immediately, a form directive that was using the code below started failing. Upon further inspection, we could see that it would only include the last param we set. The moment we removed convoyr from AppModule, both request params were back on the url.

Example:

@Injectable({providedIn: 'root'})
export class HotelUrlNameService {
  isUrlNameAvailable(hotelIdentifier: string, urlName: string): Observable<UniqueResult> {

    const params = new HttpParams()
    .set('hotelIdentifier', hotelIdentifier)
    .set('urlName', urlName)
    ;

    return this.httpClient.get<UniqueResult>(`${this.environment.inventoryAPIEndpointBaseURL}/api/administration/hotel/urlname`, { params });
  }

  constructor(private readonly httpClient: HttpClient,
              @Inject(ENVIRONMENT) private readonly environment: any) {
  }
}

[bjornharvold]

I initially thought there was a regression error with @angular/router and filed a ticket here: angular/angular#43999. But realized quickly afterwards that this has to do with this library.