Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make themes more extendable by using JSON #127

Open
jsoconno opened this issue Aug 15, 2021 · 0 comments
Open

Make themes more extendable by using JSON #127

jsoconno opened this issue Aug 15, 2021 · 0 comments
Labels
help wanted Extra attention is needed new feature New feature or request

Comments

@jsoconno
Copy link
Owner

jsoconno commented Aug 15, 2021

Is your feature request related to a problem? Please describe.
No. Themes are currently working as expected.

Describe the solution you'd like
It would be interesting if instead of creating separate classes for each theme that we use JSON for configuration and ship those files with the architectures library. This might make it easier for others to extend themes or use custom themes for their company or purpose without needing to modify architectures directly. That means we also need to add a Custom theme class that takes a path to a JSON file for any user provided themes.

Describe alternatives you've considered
We could just have users contribute new themes directly to architectures, but it seems like that is more difficult and is not as extendable for users who want to locally adjust their theme settings to meet organizational or project requirements.

Additional context
None.

@jsoconno jsoconno added new feature New feature or request help wanted Extra attention is needed labels Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant