Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fetchOptions to provide custom fetch behaivor control #315

Merged
merged 4 commits into from
Aug 9, 2023
Merged

feat: add fetchOptions to provide custom fetch behaivor control #315

merged 4 commits into from
Aug 9, 2023

Conversation

Bisstocuz
Copy link
Contributor

ref: #313

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

guybedford
guybedford approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Can you please sign the CLA? Then we can get it merged and released.

@guybedford
Copy link
Member

Also, do you think we should also change the default timeout here along with this?

@Bisstocuz
Copy link
Contributor Author

This looks good to me! Can you please sign the CLA? Then we can get it merged and released.

Signed

@Bisstocuz
Copy link
Contributor Author

Also, do you think we should also change the default timeout here along with this?

For most popular package I think it's enough for 4 seconds. But for some extreme cases I think it should be 10 seconds and retry max 1 times.

@guybedford
Copy link
Member

Maybe let's add that then?

@guybedford guybedford merged commit 2c993d7 into jspm:main Aug 9, 2023
@Bisstocuz Bisstocuz deleted the feat/add-fetchopts branch August 10, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bisstocuz @CLAassistant @guybedford