Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Template strings not being extracted when using self-closing tags #155

Closed
1 task done
aleesaan opened this issue Apr 18, 2023 · 7 comments
Closed
1 task done

Comments

@aleesaan
Copy link

aleesaan commented Apr 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is this a regression?

No

Current behavior

Angular 15.1.0 has introduced self-closing tags for custom elements, but when trying to extract keys from a template using self-closing tags, no keys get extracted.

Expected behavior

Keys should be extracted also in files using self-closing tags.

Please provide a link to a minimal reproduction of the bug

Transloco Config

No response

Debug Logs

No response

Please provide the environment you discovered this bug in

Transloco: 4.2.6
Transloco Keys Manager: 3.7.0
Angular: 15.1.x
Node: 16
Package Manager: 8
OS:

Additional context

Simply updating the @angular/compiler to >=15.1 should do the trick, as it will correctly parse the nodes for files with self-closing custom tags.

I would like to make a pull request for this bug

Yes

@shaharkazaz
Copy link
Collaborator

@aleesaan This is a big issue since this also requires moving this package to ESM instead of commonjs.
Would you like to take a shot at this task? I started but didn't find the time to finish the task.

@aleesaan
Copy link
Author

The next two weeks will be tight for me as well, I'm not sure I can pick this up sorry :(

@shaharkazaz
Copy link
Collaborator

@aleesaan It's ok, it will wait until someone will have the time to contribute 🙂

@Ben305
Copy link

Ben305 commented Jun 14, 2023

Any news on this? Maybe we can share the work...

@krechtern
Copy link

We are also facing this issue.

@shaharkazaz
Copy link
Collaborator

@Ben305 I don't have the time to get to it, I tried starting but it's quite a lot of work.
Anyone who is willing is welcome to open a PR 🙂

@shaharkazaz
Copy link
Collaborator

Should be resolved by #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants