-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Template strings not being extracted when using self-closing tags #155
Comments
@aleesaan This is a big issue since this also requires moving this package to ESM instead of commonjs. |
The next two weeks will be tight for me as well, I'm not sure I can pick this up sorry :( |
@aleesaan It's ok, it will wait until someone will have the time to contribute 🙂 |
Any news on this? Maybe we can share the work... |
We are also facing this issue. |
@Ben305 I don't have the time to get to it, I tried starting but it's quite a lot of work. |
Should be resolved by #180 |
Is there an existing issue for this?
Is this a regression?
No
Current behavior
Angular 15.1.0 has introduced self-closing tags for custom elements, but when trying to extract keys from a template using self-closing tags, no keys get extracted.
Expected behavior
Keys should be extracted also in files using self-closing tags.
Please provide a link to a minimal reproduction of the bug
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Additional context
Simply updating the
@angular/compiler
to >=15.1 should do the trick, as it will correctly parse the nodes for files with self-closing custom tags.I would like to make a pull request for this bug
Yes
The text was updated successfully, but these errors were encountered: