Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums and other decls members have incorrect highlighting #10

Closed
rauhul opened this issue Dec 16, 2023 · 4 comments
Closed

Enums and other decls members have incorrect highlighting #10

rauhul opened this issue Dec 16, 2023 · 4 comments

Comments

@rauhul
Copy link

rauhul commented Dec 16, 2023

Firstly, thanks for maintaining this library!

I think a recent change broke how declaration members are rendered. If you take a look at this snippet from swift-mmio you can see the enum cases are highlighted incorrectly:
https://github.com/apple/swift-mmio/blob/496ae117d5993036d0862e407fca9ada4f4270e5/Tests/MMIOFileCheckTests/FileCheck.swift#L12-L15

Screenshot 2023-12-15 at 8 24 47 PM
@jtbandes
Copy link
Owner

Thanks for the report. There must be some changes I made that are not working with GitHub's highlighter, but are working fine with VS Code. 😢

I'll try to look into these soon but unfortunately GitHub only updates their grammars to the latest version every few months, so it may be a while before it's fixed.

@jtbandes
Copy link
Owner

jtbandes commented Jan 2, 2024

I believe this is an error with GitHub's highlighter; you can follow along at: github-linguist/linguist#6668

@jtbandes
Copy link
Owner

The underlying issue with GitHub has been fixed. Sadly, GitHub is no longer using this tmLanguage grammar: github-linguist/linguist#6668 (comment)

@rauhul
Copy link
Author

rauhul commented Mar 12, 2024

Regardless of them switching over, truly thank you for keeping this grammar alive, it's been very helpful. I appreciate the time and effort you've put into making this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants