-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8.2.1 requires custom config when used with serverless-esbuild #349
Comments
Hi @r-token , I need more details about your setup. The issue that you are getting is because you are using a plugin to compile to your code (I assume that from Typescript) and it's trying to compile the warmup lambda. The order in which you declare the plugins matters. |
Hey @juanjoDiaz, great info - I'm sure you are correct. I am using serverless-esbuild, though declaring the warmup plugin after esbuild did not resolve the issue. serverless-esbuild allows you to exclude files from its build step. Where is that |
@juanjoDiaz I was able to resolve this with the following steps:
That fixed the initial error and it could compile that file properly, but I was then getting an error saying So step two was:
I was then able to deploy successfully with v8.3.0. Thank you for the help here! If this is an acceptable resolution then I think we can consider this issue closed. |
Hey @r-token , just ran into this problem myself. Any chance you can share some of the config setup you needed to make in order to get it to run? |
For those coming to this later and needing some more info: I added an esbuild.config.js with this:
And modified my serverless.yaml like this:
|
Thanks, @ElChapitan and @r-token. Setting the import type { AWS } from '@serverless/typescript';
const serverlessConfiguration: AWS = {
custom: {
esbuild: {
bundle: true,
minify: true,
sourcemap: false,
exclude: ['aws-sdk'],
resolveExtensions: ['.ts', '.js', '.mjs'],
target: 'node20',
platform: 'node',
concurrency: 10,
}
}
} |
As a follow up for those coming after, that worked for me as well. |
After upgrading from v8.1.0 and attempting a deploy, I get an error saying the following:
Error: Compilation failed for function alias warmUpPluginDefault. Please ensure you have an index file with ext .ts or .js, or have a path listed as main key in package.json
Version 8.1.0 compiles and deploys successfully, but 8.2.1 and 8.3.0 both return this error and fail to deploy.
I need to use one of these newer versions as AWS is end-of-lifeing Node 16 in June.
The text was updated successfully, but these errors were encountered: