Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description error? #350

Closed
nbcchen opened this issue Feb 15, 2024 · 3 comments
Closed

Description error? #350

nbcchen opened this issue Feb 15, 2024 · 3 comments

Comments

@nbcchen
Copy link

nbcchen commented Feb 15, 2024

In the Configuration section of the README, I see this sentence:

role Role to apply to the warmer lambda (defaults to the role in the provider)

In reality it creates a role that allows lambda:InvokeFunction on the other functions on the stack. Is it an error on the description?

@juanjoDiaz
Copy link
Owner

Hi @nbcchen ,

Can you give me an example YAML or a project to replicate the issue?

The role setting should simply apply this role to the function.
If no role is provided, then the default role should be created.

@nbcchen
Copy link
Author

nbcchen commented Feb 15, 2024

@juanjoDiaz
in the README it describe the role node as below
Role to apply to the warmer lambda (defaults to the role in the provider)

But it does not default to the role in the provider, it instead generates a new role called WarmUpPluginDefaultRole

@juanjoDiaz
Copy link
Owner

You are right!
This changed in v5 as stated in the documentation.
But it seems that one part of the docs was not fixed.

Fixed now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants