Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build WebP and AVIF support into Docker images #177

Closed
aentwist opened this issue Mar 30, 2023 · 3 comments · Fixed by #178
Closed

Build WebP and AVIF support into Docker images #177

aentwist opened this issue Mar 30, 2023 · 3 comments · Fixed by #178

Comments

@aentwist
Copy link
Contributor

aentwist commented Mar 30, 2023

User Story

I am working on adding WebP and AVIF preview support to Nextcloud nextcloud/server#13552. I need support for these.

Proposed Solution

Install WebP and AVIF in the images for which the PHP version supports each (that is, GD supports?).

I think this is what is required (not sure, brand new to PHP):

  • install libwebp-dev
  • install libavif-dev libaom-dev libdav1d-dev (taken directly from the below project's script, consider just libavif-dev if possible)
  • configure GD --with-webp --with-avif

Alternative Considerations

  • docker-php-extension-installer - less work for you, looks like a great project
  • do not remove the source lists in your Docker image, so I can install the dang things myself

Notes

The official images already have WebP.

See https://github.com/nextcloud/docker/blob/3eb80c52b129b4fbe8bd041fd0ba3ee0262e823a/Dockerfile-debian.template#L41
and https://github.com/nextcloud/docker/blob/3eb80c52b129b4fbe8bd041fd0ba3ee0262e823a/Dockerfile-debian.template#L47

@juliusknorr
Copy link
Owner

I'd be glad to add that. Would you be up for opening a pull request?

@aentwist
Copy link
Contributor Author

Yeeep guess so. I should be able to get around to it tomorrow.

@aentwist
Copy link
Contributor Author

aentwist commented Apr 2, 2023

Note that this might not be deployed. For up-to-date deployment information see Packages.

I built the image locally and updated my Compose file to reference it instead of the deployed image before this was even merged, so I am not blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants