-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Naas Storage API notebook #2537
feat: Naas Storage API notebook #2537
Conversation
@l-loic, i checked your notebook and it does respect our framework. |
@l-loic, it's hard to review as the notebook is huge and has information about differents functions.
|
…ions-using-naas-python-for-storage
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11541006 | Triggered | Generic Password | 70e2000 | Naas API/Naas_API_Update_Asset.ipynb | View secret |
11541006 | Triggered | Generic Password | 70e2000 | Naas API/Naas_API_Get_Asset.ipynb | View secret |
3347580 | Triggered | GitHub Access Token | 70e2000 | GitHub/GitHub_Get_commits_ranking_from_repository.ipynb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@FlorentLvr hi, you may review |
@l-loic , as we discussed, I test your notebooks and it failed on:
OK:
|
Fixes
This PR resolves #2523
What does this PR do?
Naas Storage API Notebook