Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #161 Breaks install of jupyter. #166

Closed
milesgranger opened this issue Sep 28, 2018 · 4 comments
Closed

PR #161 Breaks install of jupyter. #166

milesgranger opened this issue Sep 28, 2018 · 4 comments

Comments

@milesgranger
Copy link

milesgranger commented Sep 28, 2018

PR #161 breaks current installation of jupyter.
Creates a dependency conflict with prompt-tools & jupyter console.

ipython 7.0.1 has requirement prompt-toolkit<2.1.0,>=2.0.0, but you'll have prompt-toolkit 1.0.15 which is incompatible.

Replicate:
pip install jupyter

@s-weigand
Copy link
Contributor

How can #161 break jupyter, when it just got merged and isn't on PyPi yet? 😕
I think IPython>=7.0 breaks the jupyter installation, since the jupyter-console version on PyPi (5.2.0, Aug 21, 2017 ) doesn't include #161.
If you run pip install git+https://github.com/jupyter/jupyter_console, all should work again (just testsed it in a fresh env).
I hope that helps :bowtie:

@milesgranger
Copy link
Author

milesgranger commented Sep 28, 2018

Maybe my mistake then.. all I know is all our tests installing jupyter began suddenly failing today and passed yesterday, and it referenced a dep incompatibility between jupyter-console and prompt-tools; and I see a PR involving prompt-tools here. Sorry for the trouble. 👍

@s-weigand
Copy link
Contributor

Glad I could help 👍

@astrojuanlu
Copy link

@milesgranger I was about to point you to #158 (comment) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants