-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate bundler mini-API from jupyter-incubater/contentmanagement to notebook #1469
Comments
I think the feature is more or less reasonable. I've marked is as 5.0. |
Thanks for having a look @Carreau. |
Fine with this, but because this makes a change to the server (which is also used for jupyterlab), we need to make sure that the server side of this will work with both notebook and jupyterlab. We definitely don't want to get into a situation where we have two server. |
I'm planning on making a first pass through porting what currently exists over nearly verbatim and only enabling it against the existing notebook UI to start. I hope then we can more easily see what needs to be adapted to fit jupyterlab, assuming we want to enable the idea of bundlers there too as well. I believe the server side is pretty agnostic as to the UI. The client side JS will surely need translation to fit jupyterlab vs the current notebook. |
Yes. Thanks @takluyver . Didn't realize this was still lurking. |
Testing the waters here to see if I take the time to migrate all or part of the bundler ability out of the incubator project into a PR against notebook if it will past muster for inclusion.
Current implementation doc
https://github.com/jupyter-incubator/contentmanagement#write-bundlers
Use case
As a notebook user, I want to extend the available options under the File menu for transforming and/or packaging a notebook for download or deployment.
Problem
File -> Download As
is fixed on both the server and client.Solution already implemented in the incubator
jupyter
command line.Note
This feature is used heavily in the dashboards projects (e.g., by https://github.com/jupyter-incubator/dashboards_bundler) but has applicability beyond dashboards (e.g., bundle notebook-associated local files in a zip for download, https://github.com/jupyter-incubator/kernel_gateway_bundlers).
The text was updated successfully, but these errors were encountered: