Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enter command mode" has no function in keyboard shortcut editor #2190

Closed
mpacer opened this issue Feb 14, 2017 · 2 comments
Closed

"Enter command mode" has no function in keyboard shortcut editor #2190

mpacer opened this issue Feb 14, 2017 · 2 comments

Comments

@mpacer
Copy link
Member

mpacer commented Feb 14, 2017

The keyboard shortcut editor seems to only apply to keys that are pressed while in command mode. So the "enter command mode" shortcut is not really meaningful. It also doesn't pick up either of the two explicitly bound ways to enter command mode Esc and ⌃M.

This isn't needed for the beta, but it should be addressed at some point.

@minrk
Copy link
Member

minrk commented Feb 16, 2017

Good catch, thanks @michaelpacer

@jtpio
Copy link
Member

jtpio commented Jan 31, 2024

Closing as this is unlikely to be documented here in this repo anymore, as Notebook 7+ is now built on top of JupyterLab.

For those still interested, a good place to follow-up might be https://github.com/jupyter/nbclassic.

Thanks!

@jtpio jtpio closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants